Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook event log retention policy configuration #289

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

spwitt
Copy link
Contributor

@spwitt spwitt commented Jul 26, 2024

@spwitt spwitt requested a review from mmanes October 17, 2024 20:31
@spwitt spwitt marked this pull request as ready for review October 17, 2024 20:31
ConfigMode: schema.SchemaConfigModeAttr,
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"enabled": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work, but there is also a fusionauth.Enableable struct that you may want to use to reduce boilerplate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was modeling this after the way that audit log configuration does it. None of the other Enableables use that struct in this resourceSystemConfiguration() function, but I did notice the new configuration was missing in getDefaultSystemConfigurationRequest() and added it there using fusionauth.Enableable.

Is fusionauth.Enableable usable in this function, and it's just not using that pattern? I admit I may need an example to reference for that update.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test this locally. I think that fusionauth.Enableable is from the go client, but this portion is describing what it looks like in TF. I don't think it's possible to use that type here, but I was able to apply changes using this new configuration.

@spwitt spwitt merged commit 30c08e2 into main Oct 18, 2024
1 check passed
@spwitt spwitt deleted the spencer/eng-175/webhook-event-log branch October 18, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants